# HG changeset patch # User Dan # Date 1239898747 14400 # Node ID e2971f4a3123058c6864347bf921c0111a5a05d2 # Parent e964577b5fa90dd175983eca32acf7399439b82c QA: Fixed bad update of user info when user_rank is NULL in Admin:UserManager diff -r e964577b5fa9 -r e2971f4a3123 plugins/admin/UserManager.php --- a/plugins/admin/UserManager.php Thu Apr 16 00:55:13 2009 -0400 +++ b/plugins/admin/UserManager.php Thu Apr 16 12:19:07 2009 -0400 @@ -356,8 +356,10 @@ foreach ( $to_update_users as $key => $unused_crap ) { $value =& $to_update_users[$key]; - $value = $db->escape($value); - $update_sql .= ( empty($update_sql) ? '' : ',' ) . "$key='$value'"; + if ( $value !== 'NULL' ) + $value = "'" . $db->escape($value) . "'"; + + $update_sql .= ( empty($update_sql) ? '' : ',' ) . "$key=$value"; } $update_sql = 'UPDATE '.table_prefix."users SET $update_sql WHERE user_id=$user_id;";